[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] net: drop_monitor: make drop_monitor built-in
On Wed, Mar 11, 2020 at 2:50 PM Masahiro Yamada <> wrote:
> In net/Kconfig, NET_DEVLINK implies NET_DROP_MONITOR.
> The original behavior of the 'imply' keyword prevents NET_DROP_MONITOR
> from being 'm' when NET_DEVLINK=y.
> With the planned Kconfig change that relaxes the 'imply', the
> combination of NET_DEVLINK=y and NET_DROP_MONITOR=m would be allowed,
> causing a link error of vmlinux.
> As far as I see the mainline code, NET_DROP_MONITOR=m does not provide
> any useful case.
> The call-site of net_dm_hw_report() only exists in net/core/devlink.c,
> which is always built-in since NET_DEVLINK is a bool type option.
> So, NET_DROP_MONITOR=m causes a build error, or creates an unused
> module at best.
> Make NET_DROP_MONITOR a bool option, and remove the module exit code.
> I also unexported net_dm_hw_report because I see no other call-site
> in upstream.
> Reported-by: Stephen Rothwell <>
> Signed-off-by: Masahiro Yamada <>

Sorry, I take this back.
This is probably not the right fix.

I just sent an alternative patch.

Best Regards
Masahiro Yamada

 \ /
  Last update: 2020-03-11 07:32    [W:0.034 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site