lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Bluez PATCH v1] Bluetooth: L2CAP: handle l2cap config request during open state
From
Date
Hi Howard,

> According to Core Spec Version 5.2 | Vol 3, Part A 6.1.5,
> the incoming L2CAP_ConfigReq should be handled during
> OPEN state.
>
> Signed-off-by: Howard Chung <howardchung@google.com>
>
> ---
>
> net/bluetooth/l2cap_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 697c0f7f2c1a..5e6e35ab44dd 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -4300,7 +4300,8 @@ static inline int l2cap_config_req(struct l2cap_conn *conn,
> return 0;
> }
>
> - if (chan->state != BT_CONFIG && chan->state != BT_CONNECT2) {
> + if (chan->state != BT_CONFIG && chan->state != BT_CONNECT2 &&
> + chan->state != BT_CONNECTED) {
> cmd_reject_invalid_cid(conn, cmd->ident, chan->scid,
> chan->dcid);
> goto unlock;

Any chance you can add a btmon trace excerpt for this to the commit message. It would be good to have the before and after here included.

Regards

Marcel

\
 
 \ /
  Last update: 2020-03-11 15:51    [W:0.039 / U:23.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site