lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v1 2/3] media: ov8856: Add devicetree support
On Tue, Mar 10, 2020 at 04:55:20PM +0100, Robert Foss wrote:
> On Tue, 10 Mar 2020 at 15:26, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Mar 10, 2020 at 02:46:02PM +0100, Robert Foss wrote:

...

> > > + ov8856->xvclk = devm_clk_get(&client->dev, "xvclk");
> > > + if (IS_ERR(ov8856->xvclk)) {
> > > + dev_err(&client->dev, "failed to get xvclk\n");
> > > + return -EINVAL;
> > > + }
> >
> > Previously it worked without clock provider, now you make a dependency.
> >
> > This won't work.
>
> So the ideal behavior would be to only use the xclk if it is provided?

Yes, make it optional.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-03-11 10:07    [W:0.126 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site