lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] backing-dev: refactor wb_congested_put()
On Wed, Mar 11, 2020 at 05:59:19PM -0700, Andrew Morton wrote:
> hm, it's hard to get excited over this. Open-coding the
> refcount_dec_and_lock_irqsave() internals at a callsite in order to
> make sparse happy.
>
> Is there some other way, using __acquires (for example)?

sparse is really bad at conditional lock acquisition. we have similar
problems over the vfs. but we shouldn't be obfuscating our code to make
the tool happy.

\
 
 \ /
  Last update: 2020-03-12 03:30    [W:0.065 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site