[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators

On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
<> wrote:

Hey Stefano,

>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel <> wrote:
>> Add space around operators for improving the code
>> readability.
>> Reported by
>> git diff -w shows no difference.
>> diff of the .o files before and after the changes shows no
>> Signed-off-by: Shreeya Patel <>
>This looks good to me. Further clean-ups here could probably make this
>look less messy (there are long lines, unnecessary parentheses that are
>rather confusing, especially on that 4/5 factor, "magic" constants that
>might make sense to figure out the meaning of, etc.).

Thanks for reviewing. I will surely look at the other clean-ups as well :)


>Reviewed-by: Stefano Brivio <>

Sent from my Android device with K-9 Mail. Please excuse my brevity.

 \ /
  Last update: 2020-03-11 23:31    [W:0.055 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site