[lkml]   [2020]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm/memcontrol: fix a data race in scan count

> On Feb 9, 2020, at 11:28 PM, Andrew Morton <> wrote:
> I worry about the readability/maintainability of these things. A naive
> reader who comes upon this code will wonder "why the heck is it using
> READ_ONCE?". A possibly lengthy trawl through the git history will
> reveal the reason but that's rather unkind. Wouldn't a simple
> /* modified under lru_lock, so use READ_ONCE */
> improve the situation?

Sure. I just don’t remember there are many places in the existing code which put comments for READ_ONCE() and WRITE_ONCE(). For example, kernel/locking/osq_lock.c and kernel/rcu/srcutree.c, but I suppose every subsystem could be different.
 \ /
  Last update: 2020-02-10 05:44    [W:0.044 / U:3.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site