lkml.org 
[lkml]   [2020]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 10/12] fs: Prevent DAX state change if file is mmap'ed
Date
From: Ira Weiny <ira.weiny@intel.com>

Page faults need to ensure the inode DAX configuration is correct and
consistent with the vmf information at the time of the fault. There is
no easy way to ensure the vmf information is correct if a DAX change is
in progress. Furthermore, there is no good use case to require changing
DAX configs while the file is mmap'ed.

Track mmap's of the file and fail the DAX change if the file is mmap'ed.

Signed-off-by: Ira Weiny <ira.weiny@intel.com>

---
Changes from V2:

move 'i_mapped' to struct address_space and rename mmap_count
Add inode_has_mappings() helper for FS's
Change reference to "mode" to "state"

fs/inode.c | 1 +
fs/xfs/xfs_ioctl.c | 8 ++++++++
include/linux/fs.h | 6 ++++++
mm/mmap.c | 19 +++++++++++++++++--
4 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c
index 7d0227f9e3e8..bca5c9093542 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -371,6 +371,7 @@ static void __address_space_init_once(struct address_space *mapping)
INIT_LIST_HEAD(&mapping->private_list);
spin_lock_init(&mapping->private_lock);
mapping->i_mmap = RB_ROOT_CACHED;
+ atomic64_set(&mapping->mmap_count, 0);
}

void address_space_init_once(struct address_space *mapping)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 4ff402fd6636..faba232b1f31 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -1214,6 +1214,14 @@ xfs_ioctl_setattr_dax_invalidate(
goto out_unlock;
}

+ /*
+ * If there is a mapping in place we must remain in our current state.
+ */
+ if (inode_has_mappings(inode)) {
+ error = -EBUSY;
+ goto out_unlock;
+ }
+
error = filemap_write_and_wait(inode->i_mapping);
if (error)
goto out_unlock;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 1a22cd94c4ab..3e0121626d94 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -459,6 +459,7 @@ struct address_space {
#endif
struct rb_root_cached i_mmap;
struct rw_semaphore i_mmap_rwsem;
+ atomic64_t mmap_count;
unsigned long nrpages;
unsigned long nrexceptional;
pgoff_t writeback_index;
@@ -1951,6 +1952,11 @@ static inline void enable_dax_state_static_branch(void)
#define enable_dax_state_static_branch()
#endif /* CONFIG_FS_DAX */

+static inline bool inode_has_mappings(struct inode *inode)
+{
+ return (atomic64_read(&inode->i_mapping->mmap_count) != 0);
+}
+
static inline ssize_t call_read_iter(struct file *file, struct kiocb *kio,
struct iov_iter *iter)
{
diff --git a/mm/mmap.c b/mm/mmap.c
index 7cc2562b99fd..6bb16a0996b5 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -171,12 +171,17 @@ void unlink_file_vma(struct vm_area_struct *vma)
static struct vm_area_struct *remove_vma(struct vm_area_struct *vma)
{
struct vm_area_struct *next = vma->vm_next;
+ struct file *f = vma->vm_file;

might_sleep();
if (vma->vm_ops && vma->vm_ops->close)
vma->vm_ops->close(vma);
- if (vma->vm_file)
- fput(vma->vm_file);
+ if (f) {
+ struct inode *inode = file_inode(f);
+ if (inode)
+ atomic64_dec(&inode->i_mapping->mmap_count);
+ fput(f);
+ }
mpol_put(vma_policy(vma));
vm_area_free(vma);
return next;
@@ -1830,6 +1835,16 @@ unsigned long mmap_region(struct file *file, unsigned long addr,

vma_set_page_prot(vma);

+ /*
+ * Track if there is mapping in place such that a state change
+ * does not occur on a file which is mapped
+ */
+ if (file) {
+ struct inode *inode = file_inode(file);
+
+ atomic64_inc(&inode->i_mapping->mmap_count);
+ }
+
return addr;

unmap_and_free_vma:
--
2.21.0
\
 
 \ /
  Last update: 2020-02-08 20:35    [W:0.255 / U:3.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site