lkml.org 
[lkml]   [2020]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 051/148] media: radio: wl1273: fix interrupt masking on release
    3.16.82-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 1091eb830627625dcf79958d99353c2391f41708 upstream.

    If a process is interrupted while accessing the radio device and the
    core lock is contended, release() could return early and fail to update
    the interrupt mask.

    Note that the return value of the v4l2 release file operation is
    ignored.

    Fixes: 87d1a50ce451 ("[media] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver")
    Cc: Matti Aaltonen <matti.j.aaltonen@nokia.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/media/radio/radio-wl1273.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/media/radio/radio-wl1273.c
    +++ b/drivers/media/radio/radio-wl1273.c
    @@ -1142,8 +1142,7 @@ static int wl1273_fm_fops_release(struct
    if (radio->rds_users > 0) {
    radio->rds_users--;
    if (radio->rds_users == 0) {
    - if (mutex_lock_interruptible(&core->lock))
    - return -EINTR;
    + mutex_lock(&core->lock);

    radio->irq_flags &= ~WL1273_RDS_EVENT;

    \
     
     \ /
      Last update: 2020-02-08 19:38    [W:2.381 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site