lkml.org 
[lkml]   [2020]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Ocfs2-devel] [PATCH] OCFS2: remove useless err
From
Date


On 20/2/4 19:34, Joseph Qi wrote:
>
>
> On 20/2/4 18:59, Alex Shi wrote:
>>
>>
>> 在 2020/1/26 上午9:52, Joseph Qi 写道:
>>>
>>
>>>>
>>>> @@ -708,7 +708,7 @@ static struct buffer_head *ocfs2_find_entry_el(const char *name, int namelen,
>>>> num++;
>>>>
>>>> bh = NULL;
>>>> - err = ocfs2_read_dir_block(dir, b++, &bh,
>>>> + ocfs2_read_dir_block(dir, b++, &bh,
>>>> OCFS2_BH_READAHEAD);
>>>
>>> Umm... missing error checking here?
>>
>>
>> /*
>> * This function forces all errors to -EIO for consistency with its
>> * predecessor, ocfs2_bread(). We haven't audited what returning the
>> * real error codes would do to callers. We log the real codes with
>> * mlog_errno() before we squash them.
>> */
>> static int ocfs2_read_dir_block(struct inode *inode, u64 v_block,
>> struct buffer_head **bh, int flags)
>>
>> According to ocfs2_read_dir_block comments, caller don't care the err value, func will log it.
>>
>> So is this patch ok? :)
>>
> If we got error here, it means the buffer head is invalid.
> So how about mark it as NULL and skip it?
>

Okay, in this case, bh is already NULL and will skip below,
so it looks fine to me.

\
 
 \ /
  Last update: 2020-02-05 09:41    [W:0.043 / U:3.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site