Messages in this thread |  | | From | David Laight <> | Subject | RE: [PATCH v6 08/10] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() | Date | Wed, 5 Feb 2020 14:54:07 +0000 |
| |
From: Wei Yang > Sent: 05 February 2020 09:59 ... > If it is me, I would like to take out these two similar logic out. > > For example: > > if () { > } else if () { > } else { > goto out; > }
I'm pretty sure the kernel layout rules disallow 'else if'. It is also pretty horrid unless the conditionals are all related (so it is almost a switch statement).
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
|  |