lkml.org 
[lkml]   [2020]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/14] KVM: selftests: Use a single binary for dirty/clear log test
On Tue, Feb 04, 2020 at 09:58:38PM -0500, Peter Xu wrote:
> Remove the clear_dirty_log test, instead merge it into the existing
> dirty_log_test. It should be cleaner to use this single binary to do
> both tests, also it's a preparation for the upcoming dirty ring test.
>
> The default test will still be the dirty_log test. To run the clear
> dirty log test, we need to specify "-M clear-log".

How about keeping most of these changes, which nicely clean up the
#ifdefs, but also keeping the separate test, which I think is the
preferred way to organize and execute selftests. We can use argv[0]
to determine which path to take rather than a command line parameter.

Thanks,
drew

\
 
 \ /
  Last update: 2020-02-05 10:30    [W:0.075 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site