Messages in this thread |  | | Date | Wed, 5 Feb 2020 10:28:52 +0100 | From | Andrew Jones <> | Subject | Re: [PATCH 10/14] KVM: selftests: Use a single binary for dirty/clear log test |
| |
On Tue, Feb 04, 2020 at 09:58:38PM -0500, Peter Xu wrote: > Remove the clear_dirty_log test, instead merge it into the existing > dirty_log_test. It should be cleaner to use this single binary to do > both tests, also it's a preparation for the upcoming dirty ring test. > > The default test will still be the dirty_log test. To run the clear > dirty log test, we need to specify "-M clear-log".
How about keeping most of these changes, which nicely clean up the #ifdefs, but also keeping the separate test, which I think is the preferred way to organize and execute selftests. We can use argv[0] to determine which path to take rather than a command line parameter.
Thanks, drew
|  |