[lkml]   [2020]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] staging: octeon: delete driver
On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote:
> On Tue, Feb 04, 2020 at 08:06:14PM +0000, Chris Packham wrote:
> > On Tue, 2020-02-04 at 07:09 +0000, wrote:
> > > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote:
> > On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote:
> > > My advice is to delete all the COMPILE_TEST code. That stuff was a
> > > constant source of confusion and headaches.
> >
> > I was also going to suggest this. Since the COMPILE_TEST has been a
> > source of trouble I was going to propose dropping the || COMPILE_TEST
> > from the Kconfig for the octeon drivers.
> Not having it also causes problems. I didn't originally add it for
> shits and giggles.

I wonder if the kbuild bot does enough cross compile build testing these
days to detect compile problems. It might have improved to the point
where COMPILE_TEST isn't required.

One of the things about having a bunch of dummy functions for
COMPILE_TEST is that they introduce a lot of static checker warnings.
The real function is supposed to initialize stuff but the dummy function
just returns so now we get uninitialized variable warnings etc.

dan carpenter

 \ /
  Last update: 2020-02-05 04:40    [W:0.067 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site