Messages in this thread |  | | Date | Wed, 5 Feb 2020 11:39:30 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH] ASoC: wcd934x: Add missing COMMON_CLK dependency to SND_SOC_ALL_CODECS |
| |
Hi Geert,
On Tue, 4 Feb 2020 14:18:57 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Just adding a dependency on COMMON_CLK to SND_SOC_WCD934X is not > sufficient, as enabling SND_SOC_ALL_CODECS will still select it, > breaking the build later: > > WARNING: unmet direct dependencies detected for SND_SOC_WCD934X > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMMON_CLK [=n] && MFD_WCD934X [=m] > Selected by [m]: > - SND_SOC_ALL_CODECS [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMPILE_TEST [=y] && MFD_WCD934X [=m] > ... > ERROR: "of_clk_add_provider" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined! > ERROR: "of_clk_src_simple_get" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined! > ERROR: "clk_hw_register" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined! > ERROR: "__clk_get_name" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined! > > Fix this by adding the missing dependency to SND_SOC_ALL_CODECS > > Fixes: 42b716359beca106 ("ASoC: wcd934x: Add missing COMMON_CLK dependency") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > Seen with e.g. m68k/allmodconfig.
Also seen with powerpc/allyesconfig
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
-- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] |  |