Messages in this thread |  | | From | Brendan Higgins <> | Date | Tue, 4 Feb 2020 13:14:31 -0800 | Subject | Re: [PATCH 2/3] i2c: qcom-geni: Grow a dev pointer to simplify code |
| |
On Tue, Feb 4, 2020 at 11:32 AM Stephen Boyd <swboyd@chromium.org> wrote: > > Some lines are long here. Use a struct dev pointer to shorten lines and > simplify code. The clk_get() call can fail because of EPROBE_DEFER > problems too, so just remove the error print message because it isn't > useful. > > Cc: Girish Mahadevan <girishm@codeaurora.org> > Cc: Dilip Kota <dkota@codeaurora.org> > Cc: Alok Chauhan <alokc@codeaurora.org> > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
I personally am indifferent to &pdev->dev vs. just dev, but not printing an error in the case of a defer is a definite improvement.
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
|  |