Messages in this thread |  | | From | Doug Anderson <> | Date | Tue, 4 Feb 2020 12:49:23 -0800 | Subject | Re: [PATCH v4 11/15] dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180 |
| |
Hi,
On Tue, Feb 4, 2020 at 9:49 AM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Douglas Anderson (2020-02-03 10:31:44) > > This makes the qcom,videocc bindings match the recent changes to the > > dispcc and gpucc. > > > > 1. Switched to using "bi_tcxo" instead of "xo". > > > > 2. Adds a description for the XO clock. Not terribly important but > > nice if it cleanly matches its cousins. > > > > 3. Updates the example to use the symbolic name for the RPMH clock and > > also show that the real devices are currently using 2 address cells > > / size cells and fixes the spacing on the closing brace. > > > > 4. Split into 2 files. In this case they could probably share one > > file, but let's be consistent. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Changes in v4: > > - Added Rob's review tag. > > I don't see it. I guess I should add it?
Whoops. I knew I'd mess something like this up. Looks like it got pushed without his tag but I don't think it's a big deal. For reference, he added his tag in:
https://lore.kernel.org/r/CAL_Jsq+_2E-bAbP9F6VYkWRp0crEyRGa5peuwP58-PZniVny7w@mail.gmail.com
I did manage to remove the "/bindings" from the ID as he requested, so at least I didn't mess up the important part...
-Doug
-Doug
|  |