lkml.org 
[lkml]   [2020]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 38/70] platform/x86: GPD pocket fan: Allow somewhat lower/higher temperature limits
Hi!

> From: Hans de Goede <hdegoede@redhat.com>
>
> [ Upstream commit 1f27dbd8265dbb379926c8f6a4453fe7fe26d7a3 ]
>
> Allow the user to configure the fan to turn on / speed-up at lower
> thresholds then before (20 degrees Celcius as minimum instead of 40) and
> likewise also allow the user to delay the fan speeding-up till the
> temperature hits 90 degrees Celcius (was 70).

I see it does not break anything, but I don't quite see it as a stable
material.

That said... does lower limit make sense? Spinning fans 10C might be
interesting but not wrong.

Anyway, dev_err() text is now outdated.

Best regards,
Pavel

> for (i = 0; i < ARRAY_SIZE(temp_limits); i++) {
> - if (temp_limits[i] < 40000 || temp_limits[i] > 70000) {
> + if (temp_limits[i] < 20000 || temp_limits[i] > 90000) {
> dev_err(&pdev->dev, "Invalid temp-limit %d (must be between 40000 and 70000)\n",
> temp_limits[i]);
> temp_limits[0] = TEMP_LIMIT0_DEFAULT;

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-02-04 20:13    [W:0.308 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site