Messages in this thread |  | | Date | Tue, 4 Feb 2020 17:14:52 +0100 | From | David Sterba <> | Subject | Re: [PATCH] btrfs: ref-verify: fix memory leaks |
| |
On Sat, Feb 01, 2020 at 08:38:38PM +0000, Wenwen Wang wrote: > In btrfs_ref_tree_mod(), 'ref' and 'ra' are allocated through kzalloc() and > kmalloc(), respectively. In the following code, if an error occurs, the > execution will be redirected to 'out' or 'out_unlock' and the function will > be exited. However, on some of the paths, 'ref' and 'ra' are not > deallocated, leading to memory leaks. For example, if 'action' is > BTRFS_ADD_DELAYED_EXTENT, add_block_entry() will be invoked. If the return > value indicates an error, the execution will be redirected to 'out'. But, > 'ref' is not deallocated on this path, causing a memory leak. > > To fix the above issues, deallocate both 'ref' and 'ra' before exiting from > the function when an error is encountered.
Right, the kfrees are missing. The whole function needs to be restructured otherwise it's too easy to get lost in the conditions and what needs to be cleaned up after errors but that's for a separate patch. Added to devel queue, thanks.
|  |