Messages in this thread |  | | From | Geert Uytterhoeven <> | Date | Tue, 4 Feb 2020 14:21:01 +0100 | Subject | Re: [PATCH v2] ASoC: wcd934x: Add missing COMMON_CLK dependency |
| |
Hi Srinivas,
On Tue, Feb 4, 2020 at 12:14 PM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > Looks like some platforms are not yet using COMMON CLK. > > PowerPC allyesconfig failed with below error in next > > ld: sound/soc/codecs/wcd934x.o:(.toc+0x0): > undefined reference to `of_clk_src_simple_get' > ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe': > wcd934x.c:(.text.wcd934x_codec_probe+0x3d4): > undefined reference to `.__clk_get_name' > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438): > undefined reference to `.clk_hw_register' > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474): > undefined reference to `.of_clk_add_provider' > > Add the missing COMMON_CLK dependency to fix this errors. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thanks for your patch!
But did this change really fix your PowerPC allyesconfig build? SND_SOC_ALL_CODECS will still select it...
Fix sent.
Disclaimer: tested with m68k/allmodconfig only ;-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |