Messages in this thread Patch in this message |  | | From | qiwuchen55@gmail ... | Subject | [PATCH 1/2] pstore/platform: fix potential mem leak if pstore_init_fs failed | Date | Tue, 4 Feb 2020 21:07:13 +0800 |
| |
From: chenqiwu <chenqiwu@xiaomi.com>
There is a potential mem leak when pstore_init_fs failed, since the pstore compression maybe unlikey to initialized successfully. We must clean up the allocation once this unlikey issue happens.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com> --- fs/pstore/platform.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index d896457..114dbdf15 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -822,10 +822,10 @@ static int __init pstore_init(void) allocate_buf_for_compression(); ret = pstore_init_fs(); - if (ret) - return ret; + if (ret < 0) + free_buf_for_compression(); - return 0; + return ret; } late_initcall(pstore_init); -- 1.9.1
|  |