Messages in this thread |  | | From | Sergey Senozhatsky <> | Date | Tue, 4 Feb 2020 20:22:11 +0900 | Subject | Re: [PATCH v1] printk: Declare log_wait as external variable |
| |
On (20/02/04 11:05), Andy Shevchenko wrote: > > > --- a/kernel/printk/printk.c > > > +extern wait_queue_head_t log_wait; /* Used in fs/proc/kmsg.c */ > > > DECLARE_WAIT_QUEUE_HEAD(log_wait); > > > +#else > > > +static DECLARE_WAIT_QUEUE_HEAD(log_wait); > > > +#endif /* CONFIG_PROC_FS */ > > > > [..] > > > > Since we are now introducing CONFIG_PROC_FS dependency to printk (and > > proc/kmsg already has CONFIG_PRINTK dependency), > > I'm not sure I understood. The above does not introduce any dependencies.
kernel/printk/printk.c +#ifdef CONFIG_PROC_FS ..
Not exactly "dependency"... what is the correct word here.
-ss
|  |