lkml.org 
[lkml]   [2020]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: Annotate ftrace_graph_hash pointer with __rcu
On Mon, 3 Feb 2020 11:33:01 -0500
Joel Fernandes <joel@joelfernandes.org> wrote:

> > preempt_disable_notrace();
> >
> > - if (ftrace_hash_empty(ftrace_graph_hash)) {
> > + hash = rcu_dereference_protected(ftrace_graph_hash, !preemptible());
>
> I think you can use rcu_dereference_sched() here? That way no need to pass
> !preemptible.
>
> A preempt-disabled section is an RCU "sched flavor" section. Flavors are
> consolidated in the backend, but in the front end the dereference API still
> do have flavors.

Agreed, Amol, can you send an update?

-- Steve

\
 
 \ /
  Last update: 2020-02-04 11:03    [W:0.089 / U:3.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site