Messages in this thread |  | | Subject | Re: [PATCH v6 08/10] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() | From | David Hildenbrand <> | Date | Tue, 4 Feb 2020 10:20:16 +0100 |
| |
On 04.02.20 10:13, Oscar Salvador wrote: > On Sun, Oct 06, 2019 at 10:56:44AM +0200, David Hildenbrand wrote: >> If we have holes, the holes will automatically get detected and removed >> once we remove the next bigger/smaller section. The extra checks can >> go. >> >> Cc: Andrew Morton <akpm@linux-foundation.org> >> Cc: Oscar Salvador <osalvador@suse.de> >> Cc: Michal Hocko <mhocko@suse.com> >> Cc: David Hildenbrand <david@redhat.com> >> Cc: Pavel Tatashin <pasha.tatashin@soleen.com> >> Cc: Dan Williams <dan.j.williams@intel.com> >> Cc: Wei Yang <richardw.yang@linux.intel.com> >> Signed-off-by: David Hildenbrand <david@redhat.com> > > Heh, I have been here before. > I have to confess that when I wrote my version of this I was not really 100% > about removing it, because hotplug was a sort of a "catchall" for all sort of weird > and corner-cases configurations, but thinking more about it, I cannot think of > any situation that would make this blow up. > > Reviewed-by: Oscar Salvador <osalvador@suse.de>
Thanks for your review Oscar!
-- Thanks,
David / dhildenb
|  |