lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 6/6] net: bcmgenet: reduce severity of missing clock warnings
From
Date
Hi,

Am 03.02.20 um 19:36 schrieb Nicolas Saenz Julienne:
> Hi,
> BTW the patch looks good to me too:
>
> Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> On Sat, 2020-02-01 at 13:27 -0600, Jeremy Linton wrote:
>> Hi,
>>
>> First, thanks for looking at this!
>>
>> On 2/1/20 10:44 AM, Stefan Wahren wrote:
>>> Hi Jeremy,
>>>
>>> [add Nicolas as BCM2835 maintainer]
>>>
>>> Am 01.02.20 um 08:46 schrieb Jeremy Linton:
>>>> If one types "failed to get enet clock" or similar into google
>>>> there are ~370k hits. The vast majority are people debugging
>>>> problems unrelated to this adapter, or bragging about their
>>>> rpi's. Given that its not a fatal situation with common DT based
>>>> systems, lets reduce the severity so people aren't seeing failure
>>>> messages in everyday operation.
>>>>
>>> i'm fine with your patch, since the clocks are optional according to the
>>> binding. But instead of hiding of those warning, it would be better to
>>> fix the root cause (missing clocks). Unfortunately i don't have the
>>> necessary documentation, just some answers from the RPi guys.
>> The DT case just added to my ammunition here :)
>>
>> But really, I'm fixing an ACPI problem because the ACPI power management
>> methods are also responsible for managing the clocks. Which means if I
>> don't lower the severity (or otherwise tweak the code path) these errors
>> are going to happen on every ACPI boot.
>>
>>> This is what i got so far:
> Stefan, Apart from the lack of documentation (and maybe also time), is there
> any specific reason you didn't sent the genet clock patch yet? It should be OK
> functionally isn't it?

last time i tried to specify the both clocks as suggest by the binding
document (took genet125 for wol, not sure this is correct), but this
caused an abort on the BCM2711. In the lack of documentation i stopped
further investigations. As i saw that Jeremy send this patch, i wanted
to share my current results and retestet it with this version which
doesn't crash. I don't know the reason why both clocks should be
specified, but this patch should be acceptable since the RPi 4 doesn't
support wake on LAN.

Best regards
Stefan

\
 
 \ /
  Last update: 2020-02-03 20:09    [W:0.076 / U:1.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site