[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -v2 5/7] locking/percpu-rwsem: Remove the embedded rwsem
On Mon, Feb 03, 2020 at 04:09:33PM +0100, Peter Zijlstra wrote:
> > Can you split the removal of the non-owned resem support into a separate
> > patch? I still think keeping this one and moving aio to that scheme is
> > a better idea than the current ad-hoc locking scheme that has all kinds
> > of issues.
> That's basically 2 lines of code and a comment, surely we can ressurect
> that if/when it's needed again?

Sure, I could. But then you'd still need to update your commit log for
this patch explaining why it includes unrelated changes to a different
subsystem. By splitting it you also document your changes much better.

 \ /
  Last update: 2020-02-03 18:48    [W:0.060 / U:18.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site