lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Confused about hlist_unhashed_lockless()
Date
From: Marco Elver
> Sent: 03 February 2020 15:55
>
> On Mon, 3 Feb 2020 at 16:45, David Laight <David.Laight@aculab.com> wrote:
> >
> > From: Eric Dumazet
> > > Sent: 31 January 2020 18:53
> > >
> > > On Fri, Jan 31, 2020 at 10:48 AM Eric Dumazet <edumazet@google.com> wrote:
> > > >
> > >
> > > > This is nice, now with have data_race()
> > > >
> > > > Remember these patches were sent 2 months ago, at a time we were
> > > > trying to sort out things.
> > > >
> > > > data_race() was merged a few days ago.
> > >
> > > Well, actually data_race() is not there yet anyway.
> >
> > Shouldn't it be NO_DATA_RACE() ??
>
> Various options were considered, and based on feedback from Linus,
> decided 'data_race(..)' is the best option:
> https://lore.kernel.org/linux-fsdevel/CAHk-
> =wg5CkOEF8DTez1Qu0XTEFw_oHhxN98bDnFqbY7HL5AB2g@mail.gmail.com/
>
> It's meant to be as unobtrusive as possible, and an all-caps macro was
> ruled out.

Except that it then looks like something that actually does something.

> Second, the "NO_" prefix would be incorrect, since it'd be the
> opposite of what it is. The macro is meant to document and mark a
> deliberate data race.

It should be IGNORE_DATA_RACE() then.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
\
 
 \ /
  Last update: 2020-02-03 17:06    [W:0.077 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site