lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] media: si470x-i2c: Move free() past last use of 'radio'
On Mon, Feb 03, 2020 at 02:32:45PM +0000, Greg KH wrote:
> On Mon, Feb 03, 2020 at 01:21:30PM +0000, Lee Jones wrote:
> > A pointer to 'struct si470x_device' is currently used after free:
> >
> > drivers/media/radio/si470x/radio-si470x-i2c.c:462:25-30: ERROR: reference
> > preceded by free on line 460
> >
> > Shift the call to free() down past its final use.
> >
> > NB: Not sending to Mainline, since the problem does not exist there.
>
> It doesn't exist there because of a bad merge? What commit caused the
> problem?

Ah, found it, it was 2df200ab234a ("media: si470x-i2c: add missed
operations in remove")

\
 
 \ /
  Last update: 2020-02-03 15:59    [W:0.061 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site