lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support
On 2020-01-26 11:34, Bart Van Assche wrote:
> On 2020-01-22 23:25, Can Guo wrote:
>> + /* getting Specification Version in big endian format */
>> + hba->dev_info.spec_version = desc_buf[DEVICE_DESC_PARAM_SPEC_VER] <<
>> 8 |
>> + desc_buf[DEVICE_DESC_PARAM_SPEC_VER + 1];
>
> Please use get_unaligned_be16() instead of open-coding it.
>
> Thanks,
>
> Bart.

I am just keeping symmetry with the other device descriptors,
for example w_manufacturer_id.

Thanks,

Can Guo.

\
 
 \ /
  Last update: 2020-02-03 08:17    [W:0.138 / U:2.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site