lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/6] perf annotate: Remove privsize from symbol__annotate() args
On Mon, Feb 03, 2020 at 10:24:29AM +0530, Ravi Bangoria wrote:
>
>
> On 1/30/20 4:46 PM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Jan 24, 2020 at 01:34:27PM +0530, Ravi Bangoria escreveu:
> > > privsize is passed as 0 from all the symbol__annotate() callers.
> > > Remove it from argument list.
> >
> > Right, trying to figure out when was it that this became unnecessary to
> > see if this in fact is hiding some other problem...
> >
> > It all starts in the following change, re-reading those patches...
> >
> > - Arnaldo
> >
>
> Ok, I just had a quick look at:
> https://lore.kernel.org/lkml/20171011194323.GI3503@kernel.org/
>
> This change was for python annotation support which, I guess, Jiri didn't posted
> the patches? Jiri, are you planning to post them?

yea, as I wrote in another reply, this came in as preparation
to support python code lines, which still did not get in ;-)

also I replied that this way is probably even better for that,
so that's why I'm ok with the change

jirka

\
 
 \ /
  Last update: 2020-02-03 14:31    [W:0.058 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site