Messages in this thread |  | | From | Bartosz Golaszewski <> | Date | Mon, 3 Feb 2020 12:04:57 +0100 | Subject | Re: [PATCH v4 02/13] gpiolib: have a single place of calling set_config() |
| |
sob., 1 lut 2020 o 20:52 Guenter Roeck <linux@roeck-us.net> napisał(a): > > On Tue, Dec 24, 2019 at 01:06:58PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Instead of calling the gpiochip's set_config() callback directly and > > checking its existence every time - just add a new routine that performs > > this check internally. Call it in gpio_set_config() and > > gpiod_set_transitory(). Also call it in gpiod_set_debounce() and drop > > the check for chip->set() as it's irrelevant to this config option. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > This patch made it into mainline, even though a regression was reported > against it by Geert. Please note that it is not just a theoretic problem > but _does_ indeed cause regressions. > > Guenter >
Hi Guenter,
I'm sorry for this, I was still largely unavailable for the past two weeks. I'll address it today, this time for real.
Best regards, Bartosz Golaszewski
|  |