lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id' structure
On Mon, 3 Feb 2020, Dan Carpenter wrote:

> > diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
> > index 077c68498f04..7ef0c57f07c6 100644
> > --- a/drivers/net/fddi/defxx.c
> > +++ b/drivers/net/fddi/defxx.c
> > @@ -3768,11 +3768,11 @@ static void dfx_pci_unregister(struct pci_dev *pdev)
> >
> > #ifdef CONFIG_EISA
> > static const struct eisa_device_id dfx_eisa_table[] = {
> > - { "DEC3001", DEFEA_PROD_ID_1 },
> > - { "DEC3002", DEFEA_PROD_ID_2 },
> > - { "DEC3003", DEFEA_PROD_ID_3 },
> > - { "DEC3004", DEFEA_PROD_ID_4 },
> > - { }
> > + { "DEC3001", DEFEA_PROD_ID_1 },
> > + { "DEC3002", DEFEA_PROD_ID_2 },
> > + { "DEC3003", DEFEA_PROD_ID_3 },
> > + { "DEC3004", DEFEA_PROD_ID_4 },
> > + { "" }
>
> You haven't changed runtime at all. :P (struct eisa_device_id)->sig[]
> is an array, not a pointer. There is no NULL dereference because an
> array in the middle of another array can't be NULL.

Right, the code is good as it stands (I should have more faith in my past
achievements ;) ). Except for the whitespace issue, which I suppose might
not be worth bothering to fix. Thanks for your meticulousness!

Maciej

\
 
 \ /
  Last update: 2020-02-03 11:21    [W:0.041 / U:4.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site