lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] printk: Declare log_wait as external variable
On (20/02/03 15:15), Andy Shevchenko wrote:
> Static analyzer is not happy:
>
> kernel/printk/printk.c:421:1: warning: symbol 'log_wait' was not declared. Should it be static?
>
> This is due to usage of log_wait in the other module without announcing
> its declaration to the world. I wasn't able to dug into deep history of
> reasons why it is so, and thus decide to make less invasive change, i.e.
> declaring log_wait as external variable to make static analyzer happy.

[..]

> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 633f41a11d75..43b5cb88c607 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -418,7 +418,14 @@ DEFINE_RAW_SPINLOCK(logbuf_lock);
> } while (0)
>
> #ifdef CONFIG_PRINTK
> +
> +#ifdef CONFIG_PROC_FS
> +extern wait_queue_head_t log_wait; /* Used in fs/proc/kmsg.c */
> DECLARE_WAIT_QUEUE_HEAD(log_wait);
> +#else
> +static DECLARE_WAIT_QUEUE_HEAD(log_wait);
> +#endif /* CONFIG_PROC_FS */

[..]

Since we are now introducing CONFIG_PROC_FS dependency to printk (and
proc/kmsg already has CONFIG_PRINTK dependency), then I guess I wouldn't
mind it if fs/proc/kmsg would just relocate to printk, next to devksmg
implementation. Just saying.

-ss

\
 
 \ /
  Last update: 2020-02-04 03:16    [W:0.198 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site