lkml.org 
[lkml]   [2020]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] skbuff: fix a data race in skb_queue_len()
Date


> On Feb 3, 2020, at 3:28 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> We added recently skb_queue_empty_lockless() helper, to use in these contexts.
>
> The fact that we use READ_ONCE() is more of an implementation detail I think.
>

Make sense. I’ll use lockless in naming instead.

> Also, addressing load-stearing issues without making sure the write side
> is using WRITE_ONCE() might be not enough (even if KCSAN warnings disappear)

I suppose that could be a case. I’ll have,

WRITE_ONCE(list->qlen, list->qlen - 1);

in __skb_unlink() where it had already had a few WRITE_ONCE() for other variables.
\
 
 \ /
  Last update: 2020-02-03 23:35    [W:0.064 / U:3.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site