lkml.org 
[lkml]   [2020]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 60/97] lib/stackdepot: Fix outdated comments
On Fri, Feb 28, 2020 at 02:05:33PM +0100, Pavel Machek wrote:
> Hi!
>
> > [ Upstream commit ee050dc83bc326ad5ef8ee93bca344819371e7a5 ]
> >
> > Replace "depot_save_stack" with "stack_depot_save" in code comments because
> > depot_save_stack() was replaced in commit c0cfc337264c ("lib/stackdepot:
> > Provide functions which operate on plain storage arrays") and removed in
> > commit 56d8f079c51a ("lib/stackdepot: Remove obsolete functions")
>
> This is wrong.
>
> > +++ b/lib/stackdepot.c
> > @@ -96,7 +96,7 @@ static bool init_stack_slab(void **prealloc)
> > stack_slabs[depot_index + 1] = *prealloc;
> > /*
> > * This smp_store_release pairs with smp_load_acquire() from
> > - * |next_slab_inited| above and in depot_save_stack().
> > + * |next_slab_inited| above and in stack_depot_save().
> > */
> > smp_store_release(&next_slab_inited, 1);
> > }
>
> May have been outdated for mainline, but they are actually okay for
> 4.19.

Good catch, I'll go drop this from the stable queues (4.14, 4.9, and 4.19).

greg k-h

\
 
 \ /
  Last update: 2020-02-28 14:25    [W:0.079 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site