[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 5.5 133/150] scripts/ deprioritize old Fixes: addresses
From: Douglas Anderson <>

commit 0ef82fcefb99300ede6f4d38a8100845b2dc8e30 upstream.

Recently, I found that get_maintainer was causing me to send emails to
the old addresses for maintainers. Since I usually just trust the
output of get_maintainer to know the right email address, I didn't even
look carefully and fired off two patch series that went to the wrong
place. Oops.

The problem was introduced recently when trying to add signatures from
Fixes. The problem was that these email addresses were added too early
in the process of compiling our list of places to send. Things added to
the list earlier are considered more canonical and when we later added
maintainer entries we ended up deduplicating to the old address.

Here are two examples using mainline commits (to make it easier to
replicate) for the two maintainers that I messed up recently:

$ git format-patch d8549bcd0529~..d8549bcd0529
$ ./scripts/ 0001-clk-Add-clk_hw*.patch | grep Boyd
Stephen Boyd <>...

$ git format-patch 6d1238aa3395~..6d1238aa3395
$ ./scripts/ 0001-arm64-dts-qcom-qcs404*.patch | grep Andy
Andy Gross <>

Let's move the adding of addresses from Fixes: to the end since the
email addresses from these are much more likely to be older.

After this patch the above examples get the right addresses for the two

Fixes: 2f5bd343694e ("scripts/ add signatures from Fixes: <badcommit> lines in commit message")
Signed-off-by: Douglas Anderson <>
Acked-by: Joe Perches <>
Cc: Stephen Boyd <>
Cc: Bjorn Andersson <>
Cc: Andy Gross <>
Cc: Kees Cook <>
Cc: Dan Carpenter <>
Cc: Greg Kroah-Hartman <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
Signed-off-by: Greg Kroah-Hartman <>

scripts/ | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- a/scripts/
+++ b/scripts/
@@ -932,10 +932,6 @@ sub get_maintainers {

- foreach my $fix (@fixes) {
- vcs_add_commit_signers($fix, "blamed_fixes");
- }
foreach my $email (@email_to, @list_to) {
$email->[0] = deduplicate_email($email->[0]);
@@ -974,6 +970,10 @@ sub get_maintainers {

+ foreach my $fix (@fixes) {
+ vcs_add_commit_signers($fix, "blamed_fixes");
+ }
my @to = ();
if ($email || $email_list) {
if ($email) {

 \ /
  Last update: 2020-02-27 15:18    [W:0.505 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site