lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.


On Thu, 27 Feb 2020, Jyri Sarha wrote:

> On 27/02/2020 14:02, Wambui Karuga wrote:
>> Since 987d65d01356 (drm: debugfs: make
>> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
>> fails. Therefore, remove the check and error handling of the return
>> value of drm_debugfs_create_files() as it is not needed in
>> tilcdc_debugfs_init().
>>
>> Also remove local variables that are not used after the changes, and
>> declare tilcdc_debugfs_init() as void.
>>
>> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
>
>
> Ok, so this is a part of a bigger series.
>
Yes, this was converted to a series after initial feedback. Thanks for
your review

wambui karuga.
> Acked-by: Jyri Sarha <jsarha@ti.com>
>
> I assume the series will be merged as one without my involvement. Please
> let me know if that is not the case.
>
> BR,
> Jyri
>
>> ---
>> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 17 ++++-------------
>> 1 file changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> index 0791a0200cc3..78c1877d13a8 100644
>> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> @@ -478,26 +478,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = {
>> { "mm", tilcdc_mm_show, 0 },
>> };
>>
>> -static int tilcdc_debugfs_init(struct drm_minor *minor)
>> +static void tilcdc_debugfs_init(struct drm_minor *minor)
>> {
>> - struct drm_device *dev = minor->dev;
>> struct tilcdc_module *mod;
>> - int ret;
>>
>> - ret = drm_debugfs_create_files(tilcdc_debugfs_list,
>> - ARRAY_SIZE(tilcdc_debugfs_list),
>> - minor->debugfs_root, minor);
>> + drm_debugfs_create_files(tilcdc_debugfs_list,
>> + ARRAY_SIZE(tilcdc_debugfs_list),
>> + minor->debugfs_root, minor);
>>
>> list_for_each_entry(mod, &module_list, list)
>> if (mod->funcs->debugfs_init)
>> mod->funcs->debugfs_init(mod, minor);
>> -
>> - if (ret) {
>> - dev_err(dev->dev, "could not install tilcdc_debugfs_list\n");
>> - return ret;
>> - }
>> -
>> - return ret;
>> }
>> #endif
>>
>>
>
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>

\
 
 \ /
  Last update: 2020-02-27 13:24    [W:0.043 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site