lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA
From
Date
Hi Valentin,

On 2/27/20 11:04 AM, Valentin Schneider wrote:
> Hi Lukasz,
>
> On 2/27/20 11:00 AM, Lukasz Luba wrote:
>> Fix kernel build warning in kernel/sched/fair.c when CONFIG_SCHED_SMT is
>> not set and CONFIG_NUMA_BALANCING is set.
>>
>> kernel/sched/fair.c:1524:20: warning: ‘test_idle_cores’ declared ‘static’ but never defined [-Wunused-function]
>>
>
> I've sent a similar fix yesterday at:
>
> https://lore.kernel.org/lkml/20200226121244.7524-1-valentin.schneider@arm.com/
>

I've missed it. You are referring in the commit message to wrong change
(probably HEAD of that branch), while when you try to bisect, it
will point you to
ff7db0bf24db sched/numa: Prefer using an idle CPU as a migration target
instead of comparing tasks

I think Mel can simply resend the patches with correct build if Ingo
is OK.

If Mel would decide to go with extended approach of ifdefs, then maybe
it's also good to put in there numa_idle_core(), which actually uses
these test_idle_cores() and is_core_idle()

Regards,
Lukasz

\
 
 \ /
  Last update: 2020-02-27 13:09    [W:17.831 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site