lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/2] mfd: rn5t618: add ADC subdevice for RC5T619
On Thu, 27 Feb 2020 09:40:06 +0000
Lee Jones <lee.jones@linaro.org> wrote:

> On Wed, 26 Feb 2020, Andreas Kemnade wrote:
>
> > On Wed, 26 Feb 2020 17:46:40 +0000
> > Lee Jones <lee.jones@linaro.org> wrote:
> >
> > > On Wed, 26 Feb 2020, Andreas Kemnade wrote:
> > >
> > > > On Wed, 26 Feb 2020 15:40:55 +0000
> > > > Lee Jones <lee.jones@linaro.org> wrote:
> > > >
> > > > > On Sun, 23 Feb 2020, Andreas Kemnade wrote:
> > > > >
> > > > > > This adds a subdevice for the ADC in the RC5T619
> > > > > >
> > > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > > > > ---
> > > > > > depends on:
> > > > > > https://lore.kernel.org/lkml/20191220122416.31881-1-andreas@kemnade.info/
> > > > > >
> > > > > > Changes in v3:
> > > > > > re-added it to the series because of
> > > > > > "Oh, it looks like there was a conflict. Could you collect any Acks
> > > > > > (including mine) rebase and resend please?"
> > > > >
> > > > > Looks like there is still a conflict. Sure, it's not a complicated
> > > > > fix, but that's beside the point. What tree is this set based on?
> > > > >
> > > > It must be applied on top of my rc5t619 rtc series here:
> > > > https://lore.kernel.org/lkml/20191220122416.31881-1-andreas@kemnade.info/
> > > >
> > > > I expected it to make it into 5.6 and when I first sent the RTC series
> > > > (in October) I had no idea when I will continue with other stuff.
> > > >
> > > > That is why I sent this ADC series separately, also to give the IIO
> > > > maintainer plenty of time to review.
> > >
> > > If a patch-set can or should be applied on its own, you should send it
> > > based on an upstream commit, or else things like this happen.
> > >
> > It cannot without breaking bisectability. The RTC series adds IRQ support in
> > the PMIC which is used here.
>
> Then Kconfig should reflect that.
>
> Or, if that's not possible, then you should not break-up and submit
> sets which cannot be applied by themselves. Either submit the whole
> set together, or submit them piece by piece, not submitting the next
> part until it's predecessor has been applied.
>
I will send you a complete series containing both RTC and ADC support.
Then you can decide wether you
1. apply the whole series (both things)
2. apply RTC for 5.7 and this series later
3. ignore them (not my preferred choice ;-) ).

BTW: The way I did was based on the following note in
Documentation/process/submitting-patches.rst

"If one patch depends on another patch in order for a change to be
complete, that is OK. Simply note **"this patch depends on patch X"**
in your patch description."


Regards,
Andreas
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-02-27 12:56    [W:0.051 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site