lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller
From
Date
Hi Boris,

     Thank you so much for the review comments...

On 28/2/2020 1:30 AM, Boris Brezillon wrote:
> On Thu, 27 Feb 2020 14:27:08 +0800
> "Ramuthevar, Vadivel MuruganX"
> <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add support for the Cadence QSPI controller. This controller is
>> present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs.
>> This driver has been tested on the Intel LGM SoCs.
>>
>> This driver does not support generic SPI and also the implementation
>> only supports spi-mem interface to replace the existing driver in
>> mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR
>> flash memory
> Is it really supporting SPI NORs only, or is it just that you only
> tested it with a spi-nor?

The existing drivers/mtd/spi-nor/cadence-quadspi.c supports SPI-NORs
only, because the driver is developed

such a way that it does not support other SPI based flash memories, also
never uses SPI/SPI-MEM based framework.

So we Vignesh suggested me to  develop the new driver which supports
both SPI-NOR and SPI-NAND based on the SPI-MEM framework.

>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by? What has been reported?
Sure, will remove it.
>
>> ---
>> drivers/mtd/spi-nor/Kconfig | 11 -
>> drivers/mtd/spi-nor/Makefile | 1 -
>> drivers/spi/Kconfig | 10 +
>> drivers/spi/Makefile | 1 +
>> .../spi-cadence-quadspi.c} | 641 ++++++++++-----------
> Looks like this could be split in several patches to ease the review:
>
> 1/ convert to spi-mem
> 2/ move the driver to drivers/spi
> 3/ add support for intel,lgm-qspi
>
> other than that, that's good to see one more spi-nor controller driver
> converted to spi-mem.

Agreed!, will split as per your suggestions.

Regards
Vadivel
>

\
 
 \ /
  Last update: 2020-02-28 05:12    [W:0.065 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site