[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V3] dt-bindings: mmc: sdhci-msm: Add CQE reg map

On Mon, Feb 24, 2020 at 3:58 AM Veerabhadrarao Badiganti
<> wrote:
> CQE feature has been enabled on sdhci-msm. Add CQE reg map
> and reg names that need to be supplied for supporting CQE feature.
> Signed-off-by: Veerabhadrarao Badiganti <>
> ---
> Changes since V2:
> - Dropped _mem suffix to reg names.
> Changes since V1:
> - Updated description for more clarity & Fixed typos.
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Douglas Anderson <>

I assume you'll have a follow-up fixing the driver since commit
a4080225f51d ("mmc: cqhci: support for command queue enabled host")
refers to "cqhci_mem".

Also something to keep in mind for future patches (no action needed
for this patch): most maintainers frown on making v2 of a patch
"In-Reply-To" v1 of a patch. I notice that your v3 was in-reply-to v2
and v2 was in-reply-to v1. You probably don't want to do this. One
such reference to people not liking it [1] specifically said "they
should not be replies to old versions of that patch; otherwise the
threading looks really weird and confusing."



 \ /
  Last update: 2020-02-27 21:55    [W:0.135 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site