lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH RE-SEND v1] Input: atmel_mxt_ts - correct local variable type
Date
GCC produces this warning when kernel compiled using `make W=1`:

warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
if (byte_offset >= 0 && byte_offset < cfg->mem_size) {

Tested-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---

Added my own tested-by, since I actually use this driver.

drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index ae60442efda0..bd0fc4b08608 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -1287,8 +1287,8 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data, struct mxt_cfg *cfg)
{
struct device *dev = &data->client->dev;
struct mxt_object *object;
- unsigned int type, instance, size, byte_offset;
- int offset;
+ unsigned int type, instance, size;
+ int offset, byte_offset;
int ret;
int i;
u16 reg;
--
2.24.0
\
 
 \ /
  Last update: 2020-02-27 19:14    [W:0.036 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site