lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/8] bootconfig: Set CONFIG_BOOT_CONFIG=n by default
On Thu, 27 Feb 2020 10:22:00 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> > +
> > +static int __init warn_bootconfig(char *str)
> > +{
> > + pr_warn("WARNING: 'bootconfig' found on the kernel command line but CONFIG_BOOTCONFIG is not set.\n");
> > + return 0;
> > +}
> > +early_param("bootconfig", warn_bootconfig);
>
> Yeah, let's increases kernel size for the people who don't want to jump
> on the bootconfig wagon :-(
>
> Is this really needed?

Yes, because if someone adds bootconfig to the command line they would be
expecting their bootconfig to be read. If not, we should not fail silently.

Are you really concerned about a tiny __init function that gets freed after
boot up?

-- Steve

\
 
 \ /
  Last update: 2020-02-27 15:28    [W:0.052 / U:2.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site