Messages in this thread |  | | From | Nicholas Johnson <> | Subject | Re: [PATCH v1 2/3] Revert "thunderbolt: Prevent crash if non-active NVMem file is read" | Date | Tue, 25 Feb 2020 15:33:00 +0000 |
| |
On Tue, Feb 25, 2020 at 02:56:29PM +0200, Mika Westerberg wrote: > On Mon, Feb 24, 2020 at 05:43:05PM +0000, Nicholas Johnson wrote: > > This reverts commit 03cd45d2e219301880cabc357e3cf478a500080f. > > > > Since commit cd76ed9e5913 ("nvmem: add support for write-only > > instances"), this work around is no longer required, so drop it. > > I don't think you can refer commits that only exists in your local tree. > I would just say that "since NVMem subsystem gained support for > write-only instances this workaround is not needed anymore" or somesuch. Are the commit hashes changed when applied to the kernel? If so, oops!
I will remove it in PATCH v2. > > Otherwise this looks good to me, no objections and thanks for doing this :) Glad I can be of help. :)
|  |