lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v3 02/17] media: v4l2-fwnode: Pass notifier to v4l2_async_register_fwnode_subdev()
Hi Steve,

On Sat, Feb 15, 2020 at 11:41:21AM -0800, Steve Longerbeam wrote:
> Instead of allocating a notifier in v4l2_async_register_fwnode_subdev(),
> have the caller provide one. This allows the caller to implement
> notifier ops (bind, unbind).
>
> The caller is now responsible for first initializing its notifier with a
> call to v4l2_async_notifier_init().
>
> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>

Instead of improving v4l2_async_register_fwnode_subdev(), could you convert
the users (IMX driver in this case) to call the preferred APIs instead? As
the lines below show, v4l2_async_register_fwnode_subdev() has only two
users left --- the other one of which is the IMX driver. After converting
these two, we could just remove this API.

See e.g. drivers/media/pci/intel/ipu3/ipu3-cio2.c and
drivers/media/platform/omap3isp/isp.c for examples.

> ---
> Changes in v3:
> - added the missing calls to unregister/cleanup the new subdev notifiers.
> Reported by Rui Silva.
> ---
> drivers/media/platform/video-mux.c | 8 +++++++-
> drivers/media/v4l2-core/v4l2-fwnode.c | 11 +----------
> drivers/staging/media/imx/imx6-mipi-csi2.c | 7 ++++++-
> drivers/staging/media/imx/imx7-media-csi.c | 7 ++++++-
> drivers/staging/media/imx/imx7-mipi-csis.c | 9 ++++++++-
> include/media/v4l2-fwnode.h | 12 ++++++++----
> 6 files changed, 36 insertions(+), 18 deletions(-)

--
Kind regards,

Sakari Ailus

\
 
 \ /
  Last update: 2020-02-25 16:07    [W:0.113 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site