lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 29/89] dt-bindings: display: Convert VC4 bindings to schemas
    Hi Rob,

    On Mon, Feb 24, 2020 at 12:41:07PM -0600, Rob Herring wrote:
    > On Mon, 24 Feb 2020 10:06:31 +0100, Maxime Ripard wrote:
    > > The BCM283x SoCs have a display pipeline composed of several controllers
    > > with device tree bindings that are supported by Linux.
    > >
    > > Now that we have the DT validation in place, let's split into separate
    > > files and convert the device tree bindings for those controllers to
    > > schemas.
    > >
    > > Cc: Rob Herring <robh+dt@kernel.org>
    > > Cc: devicetree@vger.kernel.org
    > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    > > ---
    > > Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 174 +------------------------------------------------------------------------
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml | 66 +++++++++++++++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml | 73 ++++++++++++++++++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml | 75 +++++++++++++++++++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml | 37 +++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml | 40 +++++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml | 37 +++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml | 42 +++++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml | 34 ++++++++++++++-
    > > Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml | 44 ++++++++++++++++++-
    > > MAINTAINERS | 2 +-
    > > 11 files changed, 449 insertions(+), 175 deletions(-)
    > > delete mode 100644 Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
    > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml
    > >
    >
    > My bot found errors running 'make dt_binding_check' on your patch:
    >
    > warning: no schema found in file: Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml: ignoring, error in schema: properties
    > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml: properties: '#clock-cells' is a dependency of 'clock-output-names'
    > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.example.dts' failed
    > make[1]: *** [Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.example.dts] Error 1
    > Makefile:1263: recipe for target 'dt_binding_check' failed
    > make: *** [dt_binding_check] Error 2
    >
    > See https://patchwork.ozlabs.org/patch/1242907
    > Please check and re-submit.

    Yeah, that was fixed in patch 31 ("dt-bindings: display: vc4: dsi: Add
    missing clock properties"). I'm not quite sure what the preferred
    approach here would be: I did a conversion as is of the binding, and
    then fixed it, or do you prefer having it all in the same patch?

    Maxime
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-02-25 12:56    [W:3.778 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site