lkml.org 
[lkml]   [2020]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] uacce: unmap remaining mmapping from user space
From
Date
Hi, Zaibo

On 2020/2/24 下午3:17, Xu Zaibo wrote:
>>   @@ -585,6 +595,13 @@ void uacce_remove(struct uacce_device *uacce)
>>           cdev_device_del(uacce->cdev, &uacce->dev);
>>       xa_erase(&uacce_xa, uacce->dev_id);
>>       put_device(&uacce->dev);
>> +
>> +    /*
>> +     * unmap remainning mapping from user space, preventing user still
>> +     * access the mmaped area while parent device is already removed
>> +     */
>> +    if (uacce->inode)
>> +        unmap_mapping_range(uacce->inode->i_mapping, 0, 0, 1);
> Should we unmap them at the first of 'uacce_remove',  and before
> 'uacce_put_queue'?
>
We can do this,
Though it does not matter, since user space can not interrupt kernel
function uacce_remove.

Thanks

\
 
 \ /
  Last update: 2020-02-25 09:34    [W:0.074 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site