lkml.org 
[lkml]   [2020]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 3/3] nvmem: Remove .read_only field from nvmem_config
Hi Nicholas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on linus/master v5.6-rc3 next-20200224]
[cannot apply to shawnguo/for-next rockchip/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Nicholas-Johnson/nvmem-Add-support-for-write-only-instances-and-clean-up/20200225-033100
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 1f836f5b10f2524d33efde47d2b694b861ecf319
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/soc/atmel/sfr.c:35:3: error: 'struct nvmem_config' has no member named 'read_only'; did you mean 'root_only'?
.read_only = true,
^~~~~~~~~
root_only

vim +35 drivers/soc/atmel/sfr.c

c3277f8ee8cdadf Kamel Bouhara 2019-10-04 32
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 33 static struct nvmem_config atmel_sfr_nvmem_config = {
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 34 .name = "atmel-sfr",
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 @35 .read_only = true,
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 36 .word_size = 4,
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 37 .stride = 4,
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 38 .size = SFR_SN_SIZE,
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 39 .reg_read = atmel_sfr_read,
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 40 };
c3277f8ee8cdadf Kamel Bouhara 2019-10-04 41

:::::: The code at line 35 was first introduced by commit
:::::: c3277f8ee8cdadf011b8390dfdb4c44ecfaa1a7a soc: at91: Add Atmel SFR SN (Serial Number) support

:::::: TO: Kamel Bouhara <kamel.bouhara@bootlin.com>
:::::: CC: Alexandre Belloni <alexandre.belloni@bootlin.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-02-25 02:20    [W:0.149 / U:4.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site