lkml.org 
[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] random: always use batched entropy for get_random_u{32,64}
Hi Tony,

On Thu, Feb 20, 2020 at 11:20 PM Tony Luck <tony.luck@gmail.com> wrote:
>
> On Sun, Feb 16, 2020 at 10:24 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>
> > > drivers/char/random.c | 12 ------------
> > > 1 file changed, 12 deletions(-)
> >
> > Looks good to me, thank for doing this:
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Perhaps also needs to update the comment above these functions.
>
> Specifically the bit that says "The quality of the random
> number is either as good as RDRAND" ... since you are
> no longer pulling from RDRAND it isn't true anymore.

Good call. I'll fix up this comment and submit v2.


Jason

\
 
 \ /
  Last update: 2020-02-21 21:09    [W:0.076 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site