lkml.org 
[lkml]   [2020]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tracing: Skip software disabled event at __synth_event_trace_end()
From
Date
Hi Steve,

On Thu, 2020-02-20 at 14:34 -0500, Steven Rostedt wrote:
> On Mon, 17 Feb 2020 18:33:40 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > > static inline void
> > > __synth_event_trace_end(struct synth_event_trace_state
> > > *trace_state)
> > > {
> > > + if (trace_state->disabled)
> > > + return;
> > > +
> >
> > Aah, I assumed that trace_state should be initialized with 0, but
> > in really, it could be just allocated on the stack.
> > We has to set trace_state->disabled = false in
> > __synth_event_trace_start().
>
> Is this patch good enough to take, or is there another one coming?
>

I think this patch is good to take. The fix for setting trace_state-
>disabled to false would be covered by this later patch:

[PATCH 2/2] tracing: Clear trace_state when starting trace

https://lore.kernel.org/lkml/158193315899.8868.1781259176894639952.stgit@devnote2/

Tom

> -- Steve

\
 
 \ /
  Last update: 2020-02-20 20:51    [W:0.074 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site