lkml.org 
[lkml]   [2020]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/8] bootconfig: Overwrite value on same key by default
On Thu, 20 Feb 2020 12:16:41 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 20 Feb 2020 21:19:22 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Currently, bootconfig does not overwrite existing value
> > on same key, but add new value to the tail of an array.
> > But this looks a bit confusing because similar syntax
> > configuration always overwrite the value by default.
>
> Should we even allow this case? Or at the very least, some output
> should be made that a value is being overwritten.

Both are OK, but I like just making it error. At this moment,
the bootconfig tool writes user-given bootconfig file to
initrd (not reformat it). This means if user ignores the warning
from bootconfig tool, they will see same warning on dmesg again.

Thank you,


>
> -- Steve
>
>
> >
> > This changes the behavior to overwrite value on same key.
> >
> > For example, if there are 2 entries
> >
> > key = value
> > ...
> > key = value2
> >
> > Then, the key is updated as below.
> >
> > key = value2
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2020-02-21 01:21    [W:0.088 / U:1.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site