lkml.org 
[lkml]   [2020]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/8] bootconfig: Remove unneeded checksum
On Thu, 20 Feb 2020 12:14:31 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 20 Feb 2020 21:19:02 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Remove checksum of bootconfig because we already use a magic
> > word to identify bootconfig. This checksum was used for
> > checking whether there is a bootconfig at the end of initrd
> > or not. Since we have a bootconfig magic word to identify
> > the bootconfig data, we do not this checksum anymore.
> >
> > Thus the block image of the initrd file with bootconfig is
> > as follows.
> >
> > [initrd][bootconfig][size(u32)][#BOOTCONFIG\n]
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> >
>
> Hmm, I think the checksum is still good to have, in case of a corrupted
> file. Does it hurt to keep it?

No problem. We can drop this patch.
I thought this check was a bit redundant since (originally) this was
introduced to identify the bootconfig.

Thank you,

>
> -- Steve


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2020-02-21 00:36    [W:0.069 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site